New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/Response Tabs not keyboard navigable #7463
Comments
@char0n I will be putting up a PR soon that addresses this issue. I would appreciate any and all feedback. Should I link the PR on the issue you mentioned as well for visibility? |
Of course, that's what we're here for ;]
Sure, the more cross-referenced we are the better. |
17 tasks
char0n
pushed a commit
that referenced
this issue
Sep 17, 2021
- Update tabs to use <button> elements instead of <a> - Add aria roles for tablist, tabs, and tabpanel - Add aria attributes for additional a11y compliance and screen reader accessibility - Replace ids with data-name attribute for tabpanels - Add cypress test 7463 and update swos-63 - Move tabs test file to tests/a11y directory - Rename test file to be more descriptive of what is being tested. - Add id attributes to both tabs and tabpanels to leverage aria-controls and aria-labelledby attributes Co-authored-by: Calvin Gonzalez <calvin.gonzalez@oddball.io> Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com> Closes #7463 Refs #7350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Q&A (please complete the following information)
Describe the bug you're encountering
The tabs implementation for
Example Value
andSchema/Model
is not keyboard navigable.To reproduce...
Steps to reproduce the behavior:
Tab
4 times to move through the elements in orderTab
press you will notice that the focused elements skip from theTry it out
button to theParameter content type
dropdown, skipping the entire tabs section.Expected behavior
The fourth tab press should focus on the element labeled
Example Value
. The nextTab
press should focus the element labeledSchema/Model
. PressingEnter
orSpace
should focus the unselected tab and update the visible tabpanel accordingly.Screenshots
Tab focus to Example Value
Tab focus to Model
Tab focus to Tabpanel section
Additional context or thoughts
Aria roles and other attributes will be necessary to accommodate screen reader a11y.
The text was updated successfully, but these errors were encountered: