Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix typo in reacy16 test app + update SDK version in test server #680

Merged
merged 1 commit into from May 2, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

test: fix typo in reacy16 test app + update SDK version in test server

Related issues

Test Plan

N/A

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

@porcellus porcellus marked this pull request as ready for review May 2, 2023 17:49
@github-actions
Copy link

github-actions bot commented May 2, 2023

size-limit report 📦

Path Size
lib/build/index.js 9.45 KB (0%)
recipe/session/index.js 9.58 KB (0%)
recipe/thirdpartyemailpassword/index.js 17.14 KB (0%)
recipe/thirdparty/index.js 13.66 KB (0%)
recipe/emailpassword/index.js 9.23 KB (0%)
recipe/emailverification/index.js 6.84 KB (0%)
recipe/passwordless/index.js 62.51 KB (0%)
recipe/thirdpartypasswordless/index.js 70.74 KB (0%)
recipe/emailverification/prebuiltui.js 19.71 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 33.44 KB (0%)
recipe/thirdparty/prebuiltui.js 17.21 KB (0%)
recipe/emailpassword/prebuiltui.js 24.54 KB (0%)
recipe/passwordless/prebuiltui.js 98.59 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 109.13 KB (0%)

@rishabhpoddar rishabhpoddar merged commit 0563742 into 0.32 May 2, 2023
19 of 23 checks passed
@rishabhpoddar rishabhpoddar deleted the test/fix_react16_typo branch May 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants