New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: google onetap example #679
Conversation
size-limit report 📦
|
@@ -0,0 +1,16 @@ | |||
""" | |||
ASGI config for app project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use nodejs
import { SuperTokensConfig } from "./config"; | ||
|
||
SuperTokens.init(SuperTokensConfig); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the dogooglen to the login page itself
insertUrlParam("code", data.credential); | ||
insertUrlParam("state", stateInfo.stateForAuthProvider); | ||
|
||
ThirdParty.signInAndUp({userContext: {oneTap: true}}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use override of recipe to get code and state instead of doing this way
signInAndUpFeature: { | ||
providers: [Google.init()], | ||
}, | ||
preAPIHook: async (context) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can do where you are calling thirdparty sign in up function itself
Summary of change
Google one tap example
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.someFunc: function () {..}
).size-limit
section ofpackage.json
with the size limit set to the current size rounded up.rollup.config.mjs
Remaining TODOs for this PR