Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Thirdparty login popup #675

Merged
merged 7 commits into from Apr 17, 2023
Merged

fix: Thirdparty login popup #675

merged 7 commits into from Apr 17, 2023

Conversation

sattvikc
Copy link
Contributor

Summary of change

Added thirdparty login with popup example

Related issues

Test Plan

Manually tested

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Apr 17, 2023
@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited

size-limit report 📦

Path Size
lib/build/index.js 8.91 KB (0%)
recipe/session/index.js 9.03 KB (0%)
recipe/thirdpartyemailpassword/index.js 41.01 KB (0%)
recipe/thirdparty/index.js 22.36 KB (0%)
recipe/emailpassword/index.js 24.6 KB (0%)
recipe/passwordless/index.js 98.2 KB (0%)
recipe/thirdpartypasswordless/index.js 115.84 KB (0%)

@rishabhpoddar rishabhpoddar merged commit bbd4adc into 0.31 Apr 17, 2023
3 of 6 checks passed
@rishabhpoddar rishabhpoddar deleted the thirdparty-login-popup branch April 17, 2023 06:40
porcellus added a commit that referenced this pull request Apr 24, 2023
@alisher-aituarov @sattvikc @porcellus
feat: thirdparty rework (#676)
126a5f0 
* add missing providers & add prop to buttonComponent

* fix: Thirdparty login popup (#675)

* fix: thirdparty popup example

* chore: changelog

* fix: adding backend

* fix: pr comment

* fix: pr comment

* fix: pr comment

* fix: pr comment

* feat: add new providers & add prop to buttonComponent

* fix: activeDirectory width

* update changelog

* Update examples/with-thirdparty-popup/README.md

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* fix: providers

* fix: move getButton to base class

* fix: review comments

* Update examples/with-thirdparty-popup/frontend/src/App.tsx

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* fixes

---------

Co-authored-by: Alisher <alisher@supertokens.com>
Co-authored-by: Sattvik Chakravarthy <sattvik@gmail.com>
Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
rishabhpoddar pushed a commit that referenced this pull request Jul 19, 2023
@alisher-aituarov @porcellus @sattvikc
feat: multitenancy (#677)
8fcfd18 
* init web-js recipes, supertokens from auth-react

* move recipe output type to types.ts

* make combined recipes use web-js version

* get rid of recipeImplementation for single recipes

* add functionOverrides to thirdpartypasswordless recipe

* add functionOverrides to thirdpartyemailpassword recipe

* get rid of one the duplicate setLoginAttemptInfo calls

* fix tests

* update changelog

* fixes after review

* move initOutput type to root types

* fix tests

* review fixes

* review fixes

* add build files

* use normalisedConfig for webjs init in combined recipes

* remove commented code

* disable isIE check in order to avoid error

* test fixes caused by utils

* fix typo

* rename recipeImpl -> webJSRecipe for all recipes

* add comments

* utils-> normalization_function  fix

* type changes for recipe member

* type change, renamein

* move config normalization to init for session

* Update thirdpartypasswordless comments

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* Update thirdpartyemailpassword/recipe comments

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* review fixes

* reuse action type for RecipeInitResult

* move onHandelEvent call to combined recipe overrides

* fixes-session, overrides

* add callbacks to isVerified claim

* fix exampleTestHelper

* fix build folder

* add auth-react boolean claim

* extend web-js claims

* fix tests, rename callbacks

* review fixes

* fix tests

* use web-js import instead of website

* fix type GetRedirectionURLContext, add comment, pass context to getGlobalClaim function calls

* fix duplication

* move helper function to utils

* fix emailverification wrapper type

* self review fixes

* second round review fixed

* add access-denied page

* add ability to override and change style of access-denied screen

* add denial info to access denied page

* update example apps

* fix rollup watch mac issue

* review fixes

* fix redirection priorities

* move cliam functions to session utils

* fix util function

* add unit tests for new utils function

* initial splitting

* create class for each recipe to handle routes

* review fixes for /lib

* update examples

* fix partially sessionAuth tests

* fix: typo

* fix: sessionAuth test

* update changelog

* fix lintiing issues

* fix tests

* Merge branch '0.31' into 'feat/splitting-prebuild-ui-components'

* fix: partially unit test

* fix: unit test case

* fix: broken components overriding after merge

* fix: move themeBase & fix example app

* fix: type fix

* fix: access denial info

* fix: exporting claims from auth-react

* fix: review fixes

* fix: by review comments

* fix: adjust access-denied page

* more review fixes

* fix: review fixes

* change implementataion & access denied page design

* fix: default page & review changes

* fix: default failed claim when none has callback

* css: override container width

* fix: review comments

* fix: add comment

* fix: respect rid when rendering UIs

* fix tests

* fix: add underscore prefix

* test: add test for back button

* fix: emailverification prebuilt ui

* fix: review changes

* fix no router case

* fix: prebuiltui components types exoprt

* fix: emailverification exports

* fix: test apps

* fix: adjust routing component to handle duplicate renders

* feat: clean up onSuccessRedirection and add showAccessDeniedOnFailure

* fix: e2e tests

* update changelog

* fix: example apps

* fix examples & changelog

* fix: preBuiltUI -> prebuiltui

* fix filename casing

* fix: preBuiltUI -> prebuiltui

* fix filename casing

* expose signle routing functons

* rename: prebuiltui->ui

* update test apps

* fix: unit tests

* preBuiltUI -> prebuiltui

* update changelog

* update example apps

* getSuperTokensReactRouterDomRoutes casing fix

* getSuperTokensReactRouterDomRoutes casing fix

* review fixes

* review fixes

* review fixes

* wip

* fix: review comments(preBuiltUI interface consistency)

* parent c3935c9
author Alisher <alisher@supertokens.com> 1679996212 +0400
committer Alisher <alisher@supertokens.com> 1682072680 +0400

feat: multitenancy

* feat: thirdparty rework (#676)

* add missing providers & add prop to buttonComponent

* fix: Thirdparty login popup (#675)

* fix: thirdparty popup example

* chore: changelog

* fix: adding backend

* fix: pr comment

* fix: pr comment

* fix: pr comment

* fix: pr comment

* feat: add new providers & add prop to buttonComponent

* fix: activeDirectory width

* update changelog

* Update examples/with-thirdparty-popup/README.md

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* fix: providers

* fix: move getButton to base class

* fix: review comments

* Update examples/with-thirdparty-popup/frontend/src/App.tsx

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* fixes

---------

Co-authored-by: Alisher <alisher@supertokens.com>
Co-authored-by: Sattvik Chakravarthy <sattvik@gmail.com>
Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* Update lib/ts/recipe/multitenancy/index.ts

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>

* fix: review comments

* revert providers form

* fix: review 2nd round

* fixes: getRoutingComponent

* fix: review 2nd round & embedding components fixes

* fix: review

* fix: move provider picking logic into separate wrapper

* fix: remove test data

* fix: picking providers logic & types

* fix: type fixes & move helper to utils

* fix: add getter for dynamicLoginMethods

* fix: provider selection algorithm

* fixes

* fixes

* remove memoization of providders

* fixes

* chore: minor cleanup/test fixes + migration docs

* test: revert merge issue

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes reciperouter

* fixes

* fix: update to match ADRs & new BE version

* test: multitenancy (#678)

* wip: tests

* test: additional tests

* fix: picking providers logic & types

* test: adds test case

* fix test & remove redundant test case

* fix: minor cleanup/small fix + test extension

---------

Co-authored-by: Alisher <alisher@supertokens.com>
Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>

* feat: update to latest interfaces and fix tests

* test: updated test asserts to match new behaviour

* fix: make the interface more consistent with web-js

* feat: improve typing of getClaimValue

* feat: update tests to use core + small fixes

* test: add tests for tenant id exceptions

* fix: fixed handling empty provider arrays + missing provider

* fix: fix tests

* fix: self-review fixes

* fix: self-review fixes & chores

* test: fix react 16 test app

* docs: update examples

---------

Co-authored-by: Alisher <alisher@supertokens.com>
Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
Co-authored-by: Sattvik Chakravarthy <sattvik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Assignees

@sattvikc sattvikc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sattvikc @rishabhpoddar