Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duplicate init split prebuilt UI #665

Merged
merged 98 commits into from May 2, 2023

Conversation

alisher-aituarov
Copy link
Contributor

Summary of change

Combination of #640 & #655

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the above checklist after the latest changes (I've unchecked everything)

@rishabhpoddar rishabhpoddar changed the base branch from 0.31 to 0.32 May 2, 2023 16:35
CHANGELOG.md Outdated
@@ -7,8 +7,123 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change in this

CHANGELOG.md Show resolved Hide resolved
@@ -1,14 +1,42 @@
import React, { useState } from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update google one tap example app (if this does not work on chrome, try firefox)

@rishabhpoddar rishabhpoddar merged commit 0abaff1 into 0.32 May 2, 2023
19 of 21 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/duplicate-init-split-prebuilt-ui branch May 2, 2023 17:14
@porcellus porcellus mentioned this pull request May 2, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants