Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong errors logged when --include-css and --resolve-url used concurrently #2125

Closed
cspotcode opened this issue Feb 25, 2016 · 1 comment · May be fixed by ali8889/plunker-run-plugin#3, dmitriz/fontello#4 or walmartlabs/circus-stylus#5
Closed

Wrong errors logged when --include-css and --resolve-url used concurrently #2125

cspotcode opened this issue Feb 25, 2016 · 1 comment · May be fixed by ali8889/plunker-run-plugin#3, dmitriz/fontello#4 or walmartlabs/circus-stylus#5
Labels
t: Bug

Comments

@cspotcode
Copy link
Contributor

Here is a simple reproduction case, ready to fork and run: https://gist.github.com/cspotcode/19a42c629944f4e074d5

This bug occurs when:

  1. One .styl file @requires another
  2. The second .styl file has a syntax error
  3. Both --include-css and --resolve-url are enabled (or the equivalent is done with the JavaScript API)

Instead of logging a normal error message, which is useful and shows exactly what's wrong:

unexpected "}"

...it logs this error, which I'm pretty sure is a stylus bug and not an intentional error:

Cannot read property 'nodeName' of undefined
Panya added a commit that referenced this issue Feb 26, 2016
@Panya
Wrong errors with --include-css and --resolve-url used concurrently. F…
10a7cd2 
…ixes #2125
@Panya Panya added the t: Bug label Feb 26, 2016
@Panya
Copy link
Member

Panya commented Feb 26, 2016

Thanks for the report. I've fixed this bug in the rc-0.54 branch. The fix will be in the next release.

@Panya Panya closed this as completed Feb 26, 2016
kizu pushed a commit that referenced this issue Mar 5, 2016
@Panya @kizu
Wrong errors with --include-css and --resolve-url used concurrently. F…
9b968c5 
…ixes #2125
kizu added a commit that referenced this issue Mar 5, 2016
@kizu
Merge branch 'dev'
26e04d8 
* dev: (21 commits)
  Fixed History for 0.54.0
  History up
  Evaluate variables in current-media function. Fixes #2128
  Undesired spaces with partial reference selector using ranges. Fixes #2133
  Slightly clarified an issue with combinators at ranges in partial references, re: #2134
  Validate regexp flags for match function
  Fix bug with evaluating default arguments
  Undesired spaces with partial reference selector using ranges. Fixes #2133
  Fixed bug with selectors() function. Closes #2130
  Don't parse empty imports
  Wrong errors with --include-css and --resolve-url used concurrently. Fixes #2125
  misc fixes
  Docs and History up
  SelectorParser: Added initial reference selector
  BIFs: expose "url" function by "embedurl"
  Updated history
  Bump version
  BIFs: Added "index" function
  Updated docs that where merged incorrectly
  added a slice function
  ...
@snyk-bot snyk-bot mentioned this issue Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 30, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: Bug
Projects
None yet
Milestone
No milestone
2 participants
@Panya @cspotcode