chore: Remove ESLint import/no-unresolved rule

Should be covered by TypeScript and has many false positives.
styleguidist · Nov 5, 2020 · 4a16f00 · 4a16f00
1 parent 3499c5d
commit 4a16f00
Show file tree

Hide file tree

Showing 10 changed files with 40 additions and 43 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -5,19 +5,11 @@
     "browser": true,
     "node": true
   },
-  "plugins": [
-    "compat",
-    "import",
-    "jsx-a11y"
-  ],
+  "plugins": ["compat", "import", "jsx-a11y"],
   "settings": {
     "import/resolver": {
       "node": {
-        "extensions": [
-          ".js",
-          ".json",
-          ".ts"
-        ]
+        "extensions": [".js", ".json", ".ts"]
       }
     },
     "react": {
@@ -28,22 +20,22 @@
     "valid-jsdoc": 0,
     "no-duplicate-imports": 0,
     "compat/compat": "error",
-    "import/no-unresolved": ["error", {
-      "commonjs": true,
-      "caseSensitive": true
-    }],
     "import/export": "error",
     "import/no-named-as-default-member": "error",
     "import/no-mutable-exports": "error",
     "import/no-amd": "error",
     "import/first": ["error", "absolute-first"],
     "import/no-duplicates": "error",
-    "import/extensions": ["error", "always", {
-      "js": "never",
-      "tsx": "never",
-      "ts": "never",
-      "mjs": "never"
-    }],
+    "import/extensions": [
+      "error",
+      "always",
+      {
+        "js": "never",
+        "tsx": "never",
+        "ts": "never",
+        "mjs": "never"
+      }
+    ],
     "import/no-extraneous-dependencies": "error",
     "import/newline-after-import": "error",
     "import/prefer-default-export": "error",
@@ -59,10 +51,10 @@
   },
   "overrides": [
     {
-        "files": ["*.spec.js"],
-        "rules": {
-          "compat/compat": 0
-        }
+      "files": ["*.spec.js"],
+      "rules": {
+        "compat/compat": 0
+      }
     },
     {
       "files": ["*.ts", "*.tsx"],
@@ -76,9 +68,7 @@
         }
       },
       "plugins": ["@typescript-eslint"],
-      "extends": [
-        "tamia/typescript-react"
-      ]
+      "extends": ["tamia/typescript-react"]
     }
   ]
 }
diff --git a/.prettierrc b/.prettierrc
@@ -4,13 +4,21 @@
   "trailingComma": "es5",
   "useTabs": true,
   "proseWrap": "never",
-  "overrides": [{
+  "overrides": [
+		{
     "files": "*.md",
-    "options": {
-      "printWidth": 70,
-      "useTabs": false,
-      "semi": false,
-      "trailingComma": "none"
-    }
-  }]
+			"options": {
+				"printWidth": 70,
+				"useTabs": false,
+				"semi": false,
+				"trailingComma": "none"
+			}
+		},
+		{
+    "files": "*.{json,babelrc,eslintrc,remarkrc}",
+			"options": {
+				"useTabs": false
+			}
+  	}
+	]
 }
diff --git a/dangerfile.js b/dangerfile.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line import/no-unresolved, import/extensions
+// eslint-disable-next-line import/extensions
 import { danger, warn } from 'danger';
 
 const packageChanged = danger.git.modified_files.includes('package.json');

diff --git a/examples/react-native/src/Root.js b/examples/react-native/src/Root.js
@@ -1,5 +1,5 @@
 import React, { Component } from 'react';
-// eslint-disable-next-line import/no-unresolved, import/extensions
+// eslint-disable-next-line import/extensions
 import { StyleSheet, Text, ScrollView } from 'react-native';
 import SimpleCard from './SimpleCard';
 

diff --git a/examples/react-native/src/SimpleCard.js b/examples/react-native/src/SimpleCard.js
@@ -1,5 +1,5 @@
 import React, { PureComponent } from 'react';
-// eslint-disable-next-line import/no-unresolved, import/extensions
+// eslint-disable-next-line import/extensions
 import { StyleSheet, Text, View } from 'react-native';
 import PropTypes from 'prop-types';
 

diff --git a/site/docusaurus.config.js b/site/docusaurus.config.js
@@ -12,7 +12,7 @@ module.exports = {
 			disableSwitch: true,
 		},
 		prism: {
-			// eslint-disable-next-line import/no-unresolved, import/no-extraneous-dependencies
+			// eslint-disable-next-line import/no-extraneous-dependencies
 			theme: require('prism-react-renderer/themes/nightOwlLight'),
 		},
 		navbar: {

diff --git a/src/client/index.ts b/src/client/index.ts
@@ -34,7 +34,7 @@ const scrollToOrigin = () => {
 };
 
 const render = () => {
-	// eslint-disable-next-line @typescript-eslint/no-var-requires, import/no-unresolved
+	// eslint-disable-next-line @typescript-eslint/no-var-requires
 	const styleguide = require('!!../loaders/styleguide-loader!./index.js');
 
 	ReactDOM.render(

diff --git a/test/browser.js b/test/browser.js
@@ -1,6 +1,5 @@
 /* eslint-disable no-console */
 /* eslint-disable import/no-extraneous-dependencies */
-/* eslint-disable import/no-unresolved */
 
 const puppeteer = require('puppeteer');
 const path = require('path');

diff --git a/test/run.build.js b/test/run.build.js
@@ -1,4 +1,4 @@
-/* eslint-disable no-console, import/no-unresolved */
+/* eslint-disable no-console */
 
 const styleguidist = require('../lib/scripts');
 

diff --git a/test/run.server.js b/test/run.server.js
@@ -1,4 +1,4 @@
-/* eslint-disable no-console, import/no-unresolved */
+/* eslint-disable no-console */
 
 const path = require('path');
 const styleguidist = require('../lib/scripts');