Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the repository root by default when no root is specified. #1851

Merged
merged 3 commits into from Oct 8, 2021

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Oct 8, 2021

The integration repositories are clean and should not contain any extra files. If the --gitignore option ignores any of those files, then something is wrong. This check would have caught #1846.

Changes:

  • fix: Use repository root by default.
  • fix: Add a simple cli to cspell-gitignore.
  • fix: Update README to reflect CLI
  • fix: Update PHP snapshot to reflect the ignored files.
    The ignored files are ignored by .gitignore but they are checked into the repo.
  • test: make sure the integration files checked do not change with .gitignore

The integration repositories are clean and should not contain any extra files. If the `--gitignore` option ignores any of those files, then something is wrong. This check would have caught #1846.
@github-actions github-actions bot added the test label Oct 8, 2021
- Use repository root by default.
- Add a simple cli to `cspell-gitignore`.
- Update README
- Update PHP snapshot to reflect the ignored files.
    The ignored files are ignored by `.gitignore` but they are checked into the repo.
@Jason3S Jason3S changed the title test: make sure the file checked doesn't change with .gitignore fix: Use the repository root by default when no root is specified. Oct 8, 2021
@github-actions github-actions bot added the fix label Oct 8, 2021
@Jason3S Jason3S merged commit 81d005e into main Oct 8, 2021
@Jason3S Jason3S deleted the dev-int branch October 8, 2021 15:49
@Jason3S Jason3S removed the test label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant