Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached files do not get reevaluated when a dictionary or config changes. #1852

Closed
2 tasks done
Jason3S opened this issue Oct 8, 2021 · 1 comment · Fixed by #2160
Closed
2 tasks done

Cached files do not get reevaluated when a dictionary or config changes. #1852

Jason3S opened this issue Oct 8, 2021 · 1 comment · Fixed by #2160

Comments

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 8, 2021

Info

The current cache implementation caches the signature of the top level configuration, but it does not take into account changes to dictionaries or nested configuration changes.

Example:

project/
 |- cspell.json -- uses dictionary project-words.txt
 |- README.md
 |- project-words.txt
 |- packages/
 |   |- pkg-a/
 |   |   |- cspell.json -- imports ../../cspell.json and use dictionary custom-words.txt
 |   |   |- custom-words.txt
 |   |   |- README.md

Adding / removing words from project-words.txt should cause all files to be re-checked.

Adding / removing words from packages/pkg-a/custom-words should cause all files in packages/pkg-a to be re-checked.

Kind of Issue

  • runtime - command-line tools

Which Tool or library

  • cspell -- the command-line spelling tool
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant