Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python files are Ignored #1846

Closed
Jason3S opened this issue Oct 7, 2021 · 1 comment · Fixed by #1847
Closed

Python files are Ignored #1846

Jason3S opened this issue Oct 7, 2021 · 1 comment · Fixed by #1847

Comments

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 7, 2021

The standard .gitignore file has a strange line that causes cspell to ignore all .py files.

gitignore/Python.gitignore at master · github/gitignore

*.py,cover

gets interpreted as *.py. If you remove that line, it should work. I'll see if I can find a fix.

Originally posted by @Jason3S in streetsidesoftware/vscode-spell-checker#1413 (comment)

@Jason3S Jason3S transferred this issue from streetsidesoftware/vscode-spell-checker Oct 7, 2021
@Jason3S Jason3S modified the milestones: v-next, v5.7 Oct 7, 2021
Jason3S added a commit that referenced this issue Oct 7, 2021
Fixes two issues:
- fix #1846
- And another where the following `.gitignore` lines were not matching directories:

```gitignore
*/node_modules
**/coverage
```
Jason3S added a commit that referenced this issue Oct 7, 2021
Fixes two issues:
- fix #1846
    ```gitignore
    *.py,cover
    ```
- And another where the following `.gitignore` lines were not matching directories:

    ```gitignore
    */node_modules
    **/coverage
    ```
Jason3S added a commit that referenced this issue Oct 8, 2021
The integration repositories are clean and should not contain any extra files. If the `--gitignore` option ignores any of those files, then something is wrong. This check would have caught #1846.
Jason3S added a commit that referenced this issue Oct 8, 2021
…1851)

The integration repositories are clean and should not contain any extra files. If the `--gitignore` option ignores any of those files, then something is wrong. This check would have caught #1846.

Changes:
- fix: Use repository root by default.
- fix: Add a simple cli to `cspell-gitignore`.
- fix: Update README to reflect CLI
- fix: Update PHP snapshot to reflect the ignored files.
    The ignored files are ignored by `.gitignore` but they are checked into the repo.
- test: make sure the integration files checked do not change with `.gitignore`
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant