Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] CTB return private config on media types #16060

Merged
merged 1 commit into from Mar 13, 2023

Conversation

Marc-Roig
Copy link
Contributor

What does it do?

Returns the private configuration of media attributes on the CTB. Before , when you set a media field to be private and reload the CTB, you would see the private field was not checked.

How to test it?

  1. Create a content-type with a media field
  2. Set the media-field to private
  3. Reload the page and edit the content-type
  4. See the private field is checked

Related issue(s)/PR(s)

#10105

@Marc-Roig Marc-Roig added source: core:content-type-builder Source is core/content-type-builder package pr: fix This PR is fixing a bug labels Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.10 ⚠️

Comparison is base (959cf6c) 60.68% compared to head (f370b4c) 51.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16060      +/-   ##
==========================================
- Coverage   60.68%   51.58%   -9.10%     
==========================================
  Files        1495      374    -1121     
  Lines       36875    14078   -22797     
  Branches     7358     3165    -4193     
==========================================
- Hits        22376     7262   -15114     
+ Misses      12417     5615    -6802     
+ Partials     2082     1201     -881     
Flag Coverage Δ
back 51.32% <ø> (ø)
front ?
unit_back 51.32% <ø> (ø)
unit_front ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/content-type-builder/server/utils/attributes.js 38.29% <ø> (ø)

... and 1121 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️

@joshuaellis joshuaellis linked an issue Mar 13, 2023 that may be closed by this pull request
@Marc-Roig Marc-Roig merged commit 905d251 into main Mar 13, 2023
@Marc-Roig Marc-Roig deleted the fix/private-option-on-media-attr branch March 13, 2023 17:25
@Marc-Roig Marc-Roig added this to the 4.7.2 milestone Mar 13, 2023
@alexandrebodin alexandrebodin modified the milestones: 4.8.0, 4.8.1, 4.8.2 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File field private option not working in admin
4 participants