Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled property for JSONInput (GenericInput) #16033

Merged
merged 2 commits into from Mar 13, 2023

Conversation

alvarolozano
Copy link
Contributor

@alvarolozano alvarolozano commented Mar 8, 2023

What does it do?

Describe the technical changes you did.

Why is it needed?

The GenericInput component does not currently pass the disabled attribute to the JSONInput component, so for advanced use cases, it is not possible to achieve a readonly JSON field

How to test it?

Add a new GenericInput to a wiew with type="json" and disabled={true}

Related issue(s)/PR(s)

FIXES #16030

@strapi-cla
Copy link

strapi-cla commented Mar 8, 2023

CLA assistant check
All committers have signed the CLA.

@alvarolozano alvarolozano changed the title FIXES #16030 Disabled property for JSONInput (GenericInput) Disabled property for JSONInput (GenericInput) Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +5.62 🎉

Comparison is base (87ca2cc) 60.68% compared to head (2a9979a) 66.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16033      +/-   ##
==========================================
+ Coverage   60.68%   66.31%   +5.62%     
==========================================
  Files        1495     1121     -374     
  Lines       36876    22798   -14078     
  Branches     7359     4194    -3165     
==========================================
- Hits        22380    15118    -7262     
+ Misses      12415     6800    -5615     
+ Partials     2081      880    -1201     
Flag Coverage Δ
back ?
front 66.31% <ø> (ø)
unit_back ?
unit_front 66.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 374 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshuaellis joshuaellis added source: core:content-manager Source is core/content-manager package pr: fix This PR is fixing a bug labels Mar 13, 2023
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@markkaylor markkaylor added this to the 4.7.2 milestone Mar 13, 2023
@markkaylor markkaylor marked this pull request as ready for review March 13, 2023 08:36
@markkaylor
Copy link
Contributor

@alvarolozano Everything looks good, I tested and approved. I went ahead and marked your PR as ready for review to merge but you will need to assign the CLA: #16033 (comment) before I can merge.

@alvarolozano
Copy link
Contributor Author

@alvarolozano Everything looks good, I tested and approved. I went ahead and marked your PR as ready for review to merge but you will need to assign the CLA: #16033 (comment) before I can merge.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenericInput: pass disabled to JSONInput
5 participants