[documentation]: Relations reordering #15894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
added
source: docs
Marc-Roig
changed the title
Marc-Roig
changed the title
joshuaellis
requested changes
Feb 23, 2023
jhoward1994
reviewed
Feb 23, 2023
| 1. `before`: | ||
| 1. Place **before** the element with that **id** in the list | ||
| 1. If placing before an init relation: **order = beforeRelation.order -0.5** | ||
| _(0.5 is based on the “gap” between the init relation and the one before, so it is placed in between them)_ |
There was a problem hiding this comment.
Does this mean that the value might not always be 0.5? But is computed as the gap divided by 2?
If so maybe we should make that clearer
There was a problem hiding this comment.
It should always be 0.5 in this step.
Placing a new relation between
{id: 1, order: 1}
{id: 2, order: 2}
Will result in
{id: 1, order: 1}
{id: 3, order: 1.5}
{id: 2, order: 2}
Saying that, I have rephrased the algo steps hoping it's a little bit clearer. wdyt?
jhoward1994
reviewed
Feb 23, 2023
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
joshuaellis
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Document relations reordering internals in the database layer.