Add enforcement of seats to EE

[ivanThePleasant]

What does it do?

PR adds enforcement of seats workflow to the Admin package and adds several changes to the core strapi package in order to accommodate enforcement of seats workflow.

Why is it needed?

These changes will enforce the number of users in EE mode in accordance with the project license.

How to test it?

Run the branch in development with the license: run examples/getstarted for server and packages/core/admin for admin panel. You will have to set permittedSeats to a chosen number manually, just search for the variable name. Then, try to add more users than the permitteSeats number.

[codecov]

Codecov Report

Base: 58.41% // Head: 58.46% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (52c7eba) compared to base (cf179e3).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files

@@                Coverage Diff                 @@
##           releases/4.7.0   #15734      +/-   ##
==================================================
+ Coverage           58.41%   58.46%   +0.04%     
==================================================
  Files                1545     1552       +7     
  Lines               38203    38305     +102     
  Branches             7514     7536      +22     
==================================================
+ Hits                22317    22395      +78     
- Misses              13593    13617      +24     
  Partials             2293     2293              

Flag	Coverage Δ
back	47.37% <0.00%> (-0.03%)	⬇️
front	66.11% <80.73%> (+0.06%)	⬆️
unit_back	47.37% <0.00%> (-0.03%)	⬇️
unit_front	66.11% <80.73%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/components/Notifications/Notification/index.js	66.00% <0.00%> (-7.34%)	⬇️
...icationInfosPage/components/AdminSeatInfo/index.js	0.00% <0.00%> (ø)
...c/pages/SettingsPage/pages/Users/EditPage/index.js	0.00% <ø> (ø)
...ngsPage/pages/Users/ListPage/CreateAction/index.js	0.00% <0.00%> (ø)
packages/core/strapi/ee/index.js	20.23% <0.00%> (-1.45%)	⬇️
packages/core/strapi/lib/Strapi.js	16.72% <ø> (-0.30%)	⬇️
...min/src/hooks/useLicenseLimitNotification/index.js	66.66% <66.66%> (ø)
...e/admin/hooks/useLicenseLimitNotification/index.js	90.00% <90.00%> (ø)
...ore/admin/ee/admin/hooks/useLicenseLimits/index.js	93.33% <93.33%> (ø)
packages/core/admin/admin/src/hooks/index.js	100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[joshuaellis]

I think for me the main thing that is missing is some tests for the hooks:

• useLicenseLimitNotification
• useLicenseLimits
  and AdminSeatInfo/CreateAction – I don't think this would take too long to be honest

I've left some suggestions about imports, may seem superfluous but eventually we will stop supporting the direct import paths as they're not necessary for bundle size anymore :)

[joshuaellis]

Apart from the URLs mention, from an FE perspective I'm happy with this :)

[ivanThePleasant]

Hey @joshuaellis the plans for urls was to create a small app that would redirect users to the correct payment portal depending on cloud/self hosted and if they wanted to pay by card/wire transfer. The app would have eventually grown into strapi portal that would be a wrapper for strapi services payments, but in the beginning it would be just redirecting.

We started working on it on Monday, so I pushed the code to strap/portal repo. Feel free to check it out if you want, it's a simple next app

[alexandrebodin]

@joshuaellis & @gu-stav I added rbac checks to avoid making an API call that wouldn't work.

As the code was only using hooks I went with the useQuery enable option to make this happen for now. Let me know what you think.

@Marc-Roig & @Convly I updated the backend code and fixed a few things. You can look at the commits to see the differences.

[joshuaellis]

FE looks good to me

[Marc-Roig]

LGTM, what I miss are some tests, that we could add in another PR.

[alexandrebodin]

LGTM, what I miss are some tests, that we could add in another PR.

💯

[ivanThePleasant]

😌