Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translation of profile language setting #15258

Merged

Conversation

ivan-ha
Copy link
Contributor

@ivan-ha ivan-ha commented Dec 23, 2022

What does it do?

SCR-20221223-niy

After PR #12788, the translation of profile language setting is broken since the i18n key is changed from Settings.profile.form.section.experience.documentation to Settings.profile.form.section.experience.here.

But first, one line is forgot to change

id: 'Settings.profile.form.section.experience.documentation',

Secondly, it breaks many non-EN translations if no one updated that i18n key.

This PR aimed to fix both issues.

How to test it?

Go to the profile language setting page, change to different languages, see if the highlighted hint change accordingly.

Related issue(s)/PR(s)

#12788

@ronronscelestes ronronscelestes self-assigned this Dec 23, 2022
@ronronscelestes ronronscelestes added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Dec 28, 2022
Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 60.49% // Head: 60.49% // No change to project coverage 👍

Coverage data is based on head (863b0a0) compared to base (05be584).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15258   +/-   ##
=======================================
  Coverage   60.49%   60.49%           
=======================================
  Files        1352     1352           
  Lines       33174    33174           
  Branches     6337     6337           
=======================================
  Hits        20070    20070           
  Misses      11271    11271           
  Partials     1833     1833           
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.05% <ø> (ø)
unit_back 50.35% <ø> (ø)
unit_front 65.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/core/admin/admin/src/pages/ProfilePage/index.js 67.20% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronronscelestes ronronscelestes added this to the 4.5.5 milestone Dec 28, 2022
@ronronscelestes ronronscelestes merged commit aa08a10 into strapi:main Dec 28, 2022
@ivan-ha ivan-ha deleted the fix/translation-of-profile-experience branch December 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants