Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade axios to 1.2.1 #15249

Merged
merged 2 commits into from Dec 22, 2022
Merged

Chore: Upgrade axios to 1.2.1 #15249

merged 2 commits into from Dec 22, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Dec 22, 2022

What does it do?

Upgrades axios from 0.27.2 to 1.2.1.

Why is it needed?

Users are running into issues when using newer versions of axios. We also want to make sure our dependencies are up-to-date.

Related issue(s)/PR(s)

@gu-stav gu-stav added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Dec 22, 2022
@gu-stav gu-stav added this to the 4.5.5 milestone Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 60.50% // Head: 60.50% // No change to project coverage 👍

Coverage data is based on head (59438be) compared to base (237f9bf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15249   +/-   ##
=======================================
  Coverage   60.50%   60.50%           
=======================================
  Files        1352     1352           
  Lines       33176    33176           
  Branches     6337     6337           
=======================================
  Hits        20072    20072           
  Misses      11271    11271           
  Partials     1833     1833           
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.06% <0.00%> (ø)
unit_back 50.35% <ø> (ø)
unit_front 65.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/upload/admin/src/hooks/useUpload.js 51.72% <0.00%> (ø)
...kages/core/upload/admin/src/utils/axiosInstance.js 56.25% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav merged commit 745f344 into main Dec 22, 2022
@gu-stav gu-stav deleted the chore/upgrade-axios branch December 22, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Uploads fails with axios >= 1.0.0
2 participants