Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ML table headers and asset count #15243

Merged
merged 2 commits into from Dec 22, 2022

Conversation

ronronscelestes
Copy link
Contributor

What

  • Fixed table headers missing some tooltip - to match CM table UI)
  • Fixed wrong asset count displayed - we now display total asset count instead of current page asset count

image

image

@ronronscelestes ronronscelestes added source: core:upload Source is core/upload package pr: fix This PR is fixing a bug labels Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 60.52% // Head: 60.50% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a092e99) compared to base (bd3f68f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15243      +/-   ##
==========================================
- Coverage   60.52%   60.50%   -0.03%     
==========================================
  Files        1352     1352              
  Lines       33174    33176       +2     
  Branches     6335     6337       +2     
==========================================
- Hits        20078    20072       -6     
- Misses      11264    11271       +7     
- Partials     1832     1833       +1     
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.06% <100.00%> (-0.04%) ⬇️
unit_back 50.35% <ø> (ø)
unit_front 65.06% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/upload/admin/src/components/TableList/index.js 85.45% <100.00%> (-14.55%) ⬇️
...e/upload/admin/src/pages/App/MediaLibrary/index.js 80.72% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

gu-stav
gu-stav previously approved these changes Dec 22, 2022
@ronronscelestes ronronscelestes added this to the 4.5.5 milestone Dec 22, 2022
@ronronscelestes ronronscelestes merged commit f488558 into main Dec 22, 2022
@ronronscelestes ronronscelestes deleted the fix/ML-header-tooltip-and-asset-count branch December 22, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants