fix: Content manager crashing when dynamic zone entry field is not of type string #15241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add support for using a Numeric field as the
Entry title
for a dynamic zone display.Why is it needed?
We call the
.trim()
method on the dynamic zone display'sEntry title
which works fine when the field is ofString
type. TheEntry Title
could be a number in some cases as highlighted in the related issue. These cases would cause a crash since the.trim()
method is not available in typeNumber
.How to test it?
Related issue(s)/PR(s)
Fixes #15210
Demo
Screen.Recording.2022-12-21.at.11.06.50.AM.mov