Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transalation documentation for setting page #15232

Merged

Conversation

Chessman97
Copy link
Contributor

@Chessman97 Chessman97 commented Dec 21, 2022

What does it do?

Renamed vars

Why is it needed?

Translation fix.

Related issue(s)/PR(s)

Fixes #15231

@strapi-cla
Copy link

strapi-cla commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@ronronscelestes ronronscelestes self-assigned this Dec 22, 2022
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gu-stav gu-stav added source: plugin:documentation Source is plugin/documentation package pr: fix This PR is fixing a bug labels Dec 22, 2022
@gu-stav gu-stav added this to the 4.5.5 milestone Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 60.52% // Head: 60.52% // No change to project coverage 👍

Coverage data is based on head (b7df798) compared to base (f0080e3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15232   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        1352     1352           
  Lines       33174    33174           
  Branches     6335     6335           
=======================================
  Hits        20078    20078           
  Misses      11264    11264           
  Partials     1832     1832           
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.09% <ø> (ø)
unit_back 50.35% <ø> (ø)
unit_front 65.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Convly Convly merged commit ba1d649 into strapi:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: plugin:documentation Source is plugin/documentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - incorrectly translations on settings page in documentation
5 participants