Put inversedBy only once for manyToMany and oneToOne relations when creating a content-type #15224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating a content-type
petersg83
added
source: core:content-type-builder
Codecov ReportBase: 60.34% // Head: 60.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15224 +/- ##
==========================================
- Coverage 60.34% 60.34% -0.01%
==========================================
Files 1367 1367
Lines 33268 33270 +2
Branches 6352 6353 +1
==========================================
Hits 20076 20076
- Misses 11347 11348 +1
- Partials 1845 1846 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Marc-Roig
approved these changes
Dec 21, 2022
petersg83
deleted the
fix/twice-inversed-by-when-creating-CT-with-relations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Put inversedBy only once for manyToMany and oneToOne relations when creating a content-type
Why is it needed?
A fix was already done here but it was partial (only fixing the issue when updating a content-type, not when creating it)
How to test it?
Related issue(s)/PR(s)
#15037