Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Bump DS 1.4.1 #15211

Merged
merged 4 commits into from Dec 20, 2022
Merged

[chore] Bump DS 1.4.1 #15211

merged 4 commits into from Dec 20, 2022

Conversation

ronronscelestes
Copy link
Contributor

What

  • bump DS version to 1.4.1
  • updated required state, should be passed to Field and not FieldLabel

@ronronscelestes ronronscelestes added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 60.22% // Head: 60.24% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (82c69d5) compared to base (26374dc).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15211      +/-   ##
==========================================
+ Coverage   60.22%   60.24%   +0.01%     
==========================================
  Files        1355     1354       -1     
  Lines       33048    33034      -14     
  Branches     6324     6320       -4     
==========================================
- Hits        19903    19900       -3     
+ Misses      11297    11288       -9     
+ Partials     1848     1846       -2     
Flag Coverage Δ
back 50.37% <ø> (ø)
front 64.69% <50.00%> (+0.02%) ⬆️
unit_back 50.37% <ø> (ø)
unit_front 64.69% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/content-manager/components/InputJSON/index.js 31.64% <ø> (ø)
...-manager/components/RelationInput/RelationInput.js 90.90% <ø> (ø)
...c/components/ColorPicker/ColorPickerInput/index.js 91.22% <ø> (ø)
...ntent-manager/components/InputJSON/FieldWrapper.js 66.66% <50.00%> (ø)
.../src/content-manager/components/InputJSON/Label.js 61.53% <50.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants