Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deadlocks for mysql and mariadb when creating a Nth locale #15197

Merged
merged 1 commit into from Dec 16, 2022

Conversation

petersg83
Copy link
Contributor

What does it do?

Remove the use of temporary tables for mysql dialect for the inverse order usecase

Why is it needed?

It was forgotten in this PR : #15143

How to test it?

Run the test packages/plugins/i18n/tests/content-manager/crud.test.api.js multiple times with mysql and see that it always passes.

Related issue(s)/PR(s)

#15143

@petersg83 petersg83 added source: core:database Source is core/database package pr: fix This PR is fixing a bug labels Dec 16, 2022
@petersg83 petersg83 added this to the 4.5.5 milestone Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 59.94% // Head: 59.94% // No change to project coverage 👍

Coverage data is based on head (0413f27) compared to base (ab66578).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15197   +/-   ##
=======================================
  Coverage   59.94%   59.94%           
=======================================
  Files        1350     1350           
  Lines       32838    32838           
  Branches     6265     6265           
=======================================
  Hits        19685    19685           
  Misses      11299    11299           
  Partials     1854     1854           
Flag Coverage Δ
back 50.14% <0.00%> (ø)
front 64.40% <ø> (ø)
unit_back 50.14% <0.00%> (ø)
unit_front 64.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/database/lib/entity-manager/regular-relations.js 10.09% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha I wondered what was going on with this test. Looks good

@petersg83
Copy link
Contributor Author

Thank you with for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants