Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth]: change confirmation to confirm #15195

Merged
merged 1 commit into from Dec 16, 2022
Merged

Conversation

joshuaellis
Copy link
Member

What does it do?

  • change confirmation to confirm

Why is it needed?

  • confirmation password is not correct english

confirmation password is not correct english
@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Dec 16, 2022
@joshuaellis joshuaellis added this to the 4.5.5 milestone Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 59.93% // Head: 59.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3799a38) compared to base (3e01e63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15195   +/-   ##
=======================================
  Coverage   59.93%   59.94%           
=======================================
  Files        1350     1350           
  Lines       32835    32838    +3     
  Branches     6262     6265    +3     
=======================================
+ Hits        19681    19685    +4     
+ Misses      11300    11299    -1     
  Partials     1854     1854           
Flag Coverage Δ
back 50.14% <ø> (ø)
front 64.40% <ø> (+<0.01%) ⬆️
unit_back 50.14% <ø> (ø)
unit_front 64.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/src/pages/AuthPage/components/Register/index.js 65.95% <ø> (ø)
...c/pages/AuthPage/components/ResetPassword/index.js 76.00% <ø> (ø)
.../components/EditViewDataManagerProvider/reducer.js 97.38% <0.00%> (+0.05%) ⬆️
...nt-manager/components/RepeatableComponent/index.js 33.76% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshuaellis joshuaellis merged commit c31175f into main Dec 16, 2022
@gu-stav gu-stav deleted the chore/incorrect-label branch December 16, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants