Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update qs to fix CVE-2022-24999 #15189

Merged
merged 1 commit into from Dec 15, 2022
Merged

Update qs to fix CVE-2022-24999 #15189

merged 1 commit into from Dec 15, 2022

Conversation

derrickmehaffy
Copy link
Member

Updates the qs package where possible in the codebase to fix CVE-2022-24999

@derrickmehaffy derrickmehaffy self-assigned this Dec 15, 2022
@derrickmehaffy derrickmehaffy added pr: security This PR is security issue source: dependencies Source is dependency problem labels Dec 15, 2022
petersg83
petersg83 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited

Codecov Report

Base: 59.93% // Head: 59.93% // No change to project coverage 👍

Coverage data is based on head (e09614c) compared to base (8716ecc).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15189   +/-   ##
=======================================
  Coverage   59.93%   59.93%           
=======================================
  Files        1350     1350           
  Lines       32835    32835           
  Branches     6262     6262           
=======================================
  Hits        19681    19681           
  Misses      11300    11300           
  Partials     1854     1854
Flag Coverage Δ
back 50.14% <ø> (ø)
front 64.39% <ø> (ø)
unit_back 50.14% <ø> (ø)
unit_front 64.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alexandrebodin
alexandrebodin approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good based on the changelog

@derrickmehaffy derrickmehaffy added this to the 4.5.5 milestone Dec 15, 2022
@derrickmehaffy derrickmehaffy merged commit 6f9b106 into main Dec 15, 2022
@derrickmehaffy derrickmehaffy deleted the security/qsupgrade branch December 15, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@petersg83 petersg83 petersg83 approved these changes

@Convly Convly Awaiting requested review from Convly

Assignees

@derrickmehaffy derrickmehaffy

Labels
pr: security This PR is security issue source: dependencies Source is dependency problem
Projects
None yet
Milestone
4.5.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derrickmehaffy @alexandrebodin @petersg83