fix: Loader is not displayed in Save button while creating an entry for the collection-type #15188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 60.52% // Head: 60.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #15188 +/- ##
=======================================
Coverage 60.52% 60.52%
=======================================
Files 1352 1352
Lines 33172 33172
Branches 6334 6334
=======================================
Hits 20078 20078
Misses 11263 11263
Partials 1831 1831
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ronronscelestes
approved these changes
Dec 22, 2022
ronronscelestes
added
source: core:content-manager
|
This PR was pushed through Gitstart, with contributions from @Beejay-bot, @raph941, @phunguyenmurcul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Use
loadinginstead ofisLoading(wrong name) in Save button props binding.Why is it needed?
The loading icon cannot be displayed when the save button is hit because the isLoading prop is not a valid attribute. Loading is the appropriate and correct prop because it enables the display of the loading icon while performing an action.
How to test it?
Related issue(s)/PR(s)
Fixes #15177
Demo
Screen.Recording.2022-12-15.at.4.33.45.PM.mov