Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-manager: handle complex component nesting in the UI #15176

Merged
merged 1 commit into from Dec 16, 2022

Conversation

jhoward1994
Copy link
Contributor

@jhoward1994 jhoward1994 commented Dec 14, 2022

What does it do?

Fixes a bug in content-manager/components/EditViewDataManagerProvider/reducer.js that was causing the UI to error with deeply nest content structures

How to test it?

Related issue(s)/PR(s)

fixes #15038

@jhoward1994 jhoward1994 self-assigned this Dec 14, 2022
@jhoward1994 jhoward1994 added source: core:content-manager Source is core/content-manager package pr: fix This PR is fixing a bug labels Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 59.90% // Head: 59.94% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (26c083a) compared to base (1ea8e0c).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15176      +/-   ##
==========================================
+ Coverage   59.90%   59.94%   +0.03%     
==========================================
  Files        1348     1350       +2     
  Lines       32809    32839      +30     
  Branches     6259     6265       +6     
==========================================
+ Hits        19655    19686      +31     
+ Misses      11300    11299       -1     
  Partials     1854     1854              
Flag Coverage Δ
back 50.14% <ø> (+0.05%) ⬆️
front 64.40% <83.33%> (+0.03%) ⬆️
unit_back 50.14% <ø> (+0.05%) ⬆️
unit_front 64.40% <83.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-manager/components/RepeatableComponent/index.js 33.76% <0.00%> (+0.43%) ⬆️
.../components/EditViewDataManagerProvider/reducer.js 97.38% <100.00%> (+0.05%) ⬆️
packages/core/admin/admin/src/utils/index.js 100.00% <0.00%> (ø)
packages/core/admin/server/services/metrics.js 100.00% <0.00%> (ø)
packages/core/upload/server/services/upload.js 28.57% <0.00%> (ø)
packages/core/upload/server/services/metrics.js 62.26% <0.00%> (ø)
packages/core/admin/admin/src/pages/App/index.js 66.66% <0.00%> (ø)
packages/plugins/i18n/server/services/metrics.js 100.00% <0.00%> (ø)
packages/core/strapi/lib/services/metrics/index.js 62.74% <0.00%> (ø)
...ackages/core/strapi/lib/services/metrics/sender.js 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhoward1994 jhoward1994 marked this pull request as ready for review December 16, 2022 10:37
@joshuaellis joshuaellis added this to the 4.5.5 milestone Dec 16, 2022
@jhoward1994 jhoward1994 merged commit ab66578 into main Dec 16, 2022
@jhoward1994 jhoward1994 deleted the fix/ui-nested-repeatable-components branch December 16, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin UI errors on deeply nested components with relation
2 participants