fix: Add button of repeatable components is missing a focus outline and focus handling #15174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 60.22% // Head: 60.22% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #15174 +/- ##
=======================================
Coverage 60.22% 60.22%
=======================================
Files 1355 1355
Lines 33048 33048
Branches 6324 6324
=======================================
Hits 19903 19903
Misses 11297 11297
Partials 1848 1848
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi @gu-stav, @ronronscelestes could you please take a look at solution in this PR. |
joshuaellis
requested changes
Dec 14, 2022
...ges/core/admin/admin/src/content-manager/components/RepeatableComponent/DraggedItem/index.js
Outdated
Show resolved
Hide resolved
…thub.com/GitStartHQ/strapi into fix/add-button-repeatable-components
…thub.com/GitStartHQ/strapi into fix/add-button-repeatable-components
gitstart
requested review from
joshuaellis
and removed request for
ronronscelestes
gitstart
commented
Dec 14, 2022
...admin/admin/src/content-manager/components/RepeatableComponent/AccordionGroupCustom/index.js
Show resolved
Hide resolved
joshuaellis
added
source: core:content-manager
…thub.com/GitStartHQ/strapi into fix/add-button-repeatable-components
joshuaellis
approved these changes
Dec 19, 2022
|
This PR was pushed through Gitstart, with contributions from @oxenprogrammer, @raph941, @phunguyenmurcul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds outline on
Add buttonof repeatable components once focused.Why is it needed?
The
overflow: hiddeninAccordionFooterhides the outline, removing it allows the outline ring to show when focused.How to test it?
Demo
Screen.Recording.2022-12-16.at.3.06.45.PM.mov
Related Issue
#15109