fix(upload): normalize the string used as basename #15151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-pichon
added
source: core:upload
nathan-pichon
assigned Marc-Roig and jhoward1994 and unassigned Marc-Roig and jhoward1994
Codecov ReportBase: 59.88% // Head: 59.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #15151 +/- ##
=======================================
Coverage 59.88% 59.88%
=======================================
Files 1348 1348
Lines 32809 32809
Branches 6257 6256 -1
=======================================
Hits 19647 19647
Misses 11306 11306
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nathan-pichon
force-pushed
the
fix/media-upload-diacritics
branch
from
40e0ca9
to
0cf5d3c
Compare
Marc-Roig
approved these changes
Dec 12, 2022
jhoward1994
approved these changes
Dec 13, 2022
|
@nathan-pichon Please don't forget to add a milestone when merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add a little
.normalize();function call to avoid problem with combined unicode.See documentation:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize#description
Why is it needed?
Combine unicode leads to an error in the Mysql database that doesn't use
utf8mb4charset. We may introduce the use ofutf8mb4in the future, but for now, it seems to be too big change for little added value.How to test it?
Please follow the instruction on the issue:
#14793
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request
#14793