New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fontawesome dependency #15133
Conversation
c521e4b
to
88ed9bf
Compare
b5fb74c
to
1ca2c10
Compare
Codecov ReportBase: 60.34% // Head: 60.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15133 +/- ##
==========================================
+ Coverage 60.34% 60.52% +0.18%
==========================================
Files 1367 1352 -15
Lines 33268 33172 -96
Branches 6352 6334 -18
==========================================
+ Hits 20076 20078 +2
+ Misses 11347 11263 -84
+ Partials 1845 1831 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
872c629
to
b90a03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few Q's nothing major
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiice - thank you for this, I checked every spot impacted locally and didn't run into any issues! 💃
.../core/content-type-builder/admin/src/components/ComponentCard/ComponentIcon/ComponentIcon.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💃
b516609
to
093b58d
Compare
Requested changes have been addressed.
What does it do?
Removes fontawesome from components, to reduce the bundle size:
Why is it needed?
It reduces the bundle-size from 9.97 MB to 8.01 MB.
TODO
How to test it?
Views using FA icons:
/admin/plugins/content-type-builder/content-types/api::restaurant.restaurant
/admin/content-manager/collectionType/api::kitchensink.kitchensink/create
/admin/content-manager/collectionType/api::kitchensink.kitchensink/configurations/edit
/admin/settings/users-permissions/providers
Related issue(s)/PR(s)
Fixes #14572