Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[features] Media Library list view #15085

Merged
merged 60 commits into from Dec 16, 2022
Merged

[features] Media Library list view #15085

merged 60 commits into from Dec 16, 2022

Conversation

ronronscelestes
Copy link
Contributor

@ronronscelestes ronronscelestes commented Dec 5, 2022 •
edited

What

The media library display is evolving offering the possibility to switch between a list view and a grid view.
The goal is to give an overview of the asset details to have maximum information available at first glance.
This is applied in the Media Library and the Asset Dialog.

While working on the list view, some fixes were also brought to the permissions grid view as users without update permission should not be able to access move or delete actions.

Snapshots

image

image

Tests

Switch from list view to grid view in ML and ML in CM
Check that all permissions are working the same for grid and list view

Acceptance criteria

  • Given that I am in the Media Library
    • When I click on the List view icon
      • I cannot see the Sort by button
      • I can sort on Created, Last updated, Name by clicking table headers arrow icon
    • When I click on a folder row
      • I’m redirected to the folder page
    • When I click on an asset row
      • I can see the edit asset modal open
    • When I don’t have update permissions
      • I can still access edit view of a folder or an asset
      • I can see a disabled form (inputs + actions buttons)
      • I cannot select any folder or asset
  • Given than I am in the Media Library through the Media Library Input in the CM (modals)
    • All the above is true
      • Except When I don’t have update permissions → I cannot select any folder or asset
    • When I want to select
      • I cannot select folders
      • I can only select allowed assets (through field advanced settings in CTB)

jhoward1994 and others added 30 commits November 21, 2022 15:10
@jhoward1994
feature(upload): add toggle switch in ML and ML modal
4012797
@ronronscelestes
rename AssetList to AssetGridList
9ff6c29
@ronronscelestes
set up of DynamicTable and TableRows
9c8773e
@ronronscelestes
added preview and edit icon
dadebfa
@ronronscelestes
added updatedAt column
a6af135
@ronronscelestes
added selecting assets
6e2518d
@ronronscelestes
small improvements + components tests
522c9d2
@ronronscelestes
fix FileWrapper comment eslint error
6ffa7c4
@ronronscelestes
feedback fixes
5977a2c
@ronronscelestes
added folders to table + select all rows functionnality
7297536
@ronronscelestes
rename AssetTableList to TableList
2387f8d
@ronronscelestes
small improvements + tests
bd177a0
@ronronscelestes
feedback fixes
a04305a
@ronronscelestes
refactor making cell dynamic with CellContent
a3ae131
@ronronscelestes
handleBulkSelect handler + CellContent tests additions
1d8d318
@ronronscelestes
Merge pull request #14917 from strapi/ML-listview/folders-list
632ccb3 
[features][ML listview] Assets and Folders into table listview
@jhoward1994
Merge remote-tracking branch 'origin/features/MediaLibrary-listview' …
530cb8b 
…into MediaLibrary-listview/view-switch
@jhoward1994
chore(upload): feedback
69b4b63 
feat(helper-plugin): persist upload localstroage
@ronronscelestes
integrated sort to table list view
f2fdfda
@ronronscelestes
Merge branch 'features/MediaLibrary-listview' of https://github.com/s…
92ec181 
…trapi/strapi into ML-listview/sort
@ronronscelestes
added onRowClick and folder link
cb516f8
@ronronscelestes
added stopPropagation to checkbox cells
c1b88aa
@ronronscelestes
fixed missing translation for folder link label
6621238
@ronronscelestes
remove handleClickSort out of the mapping
97a452a
@ronronscelestes
chore: feedback fixes
dbe036b
@ronronscelestes
chore: feedback fixes
c2b6052
@ronronscelestes
Merge pull request #14963 from strapi/ML-listview/sort
1ebcc5f 
[features][ML listview] Sort on table headers
@ronronscelestes
Merge branch 'features/MediaLibrary-listview' of https://github.com/s…
63d00fd 
…trapi/strapi into ML-listview/row-navigation
@ronronscelestes
Merge pull request #14965 from strapi/ML-listview/row-navigation
f568491 
[features][ML listview] Row navigation
@ronronscelestes
fixed selecting element only with can update permission
47a5691
joshuaellis
joshuaellis requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @ronronscelestes & @jhoward1994 ⭐

Some minor feedback just around comments / jsdocs 😄

packages/core/upload/admin/src/components/AssetDialog/BrowseStep/index.js Outdated Show resolved Hide resolved
packages/core/upload/admin/src/components/AssetDialog/BrowseStep/utils/isSelectable.js Outdated Show resolved Hide resolved
packages/core/upload/admin/src/utils/getFolderURL.js Show resolved Hide resolved
jhoward1994
jhoward1994 previously approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉 it works really well

@meck93 meck93 mentioned this pull request Dec 10, 2022
Closed
@Marc-Roig
Copy link
Contributor

QA done & LGTM! Amazing work 🚀

Marc-Roig
Marc-Roig previously approved these changes Dec 12, 2022
View reviewed changes
joshuaellis
joshuaellis previously approved these changes Dec 12, 2022
View reviewed changes
@pwizla pwizla mentioned this pull request Dec 12, 2022
Merged
gu-stav
gu-stav reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀 Added only a few minor questions ...

packages/core/upload/admin/src/components/TableList/CellContent.js Show resolved Hide resolved
packages/core/upload/admin/src/components/TableList/CellContent.js Outdated Show resolved Hide resolved
packages/core/upload/admin/src/components/TableList/PreviewCell.js Show resolved Hide resolved
packages/core/upload/admin/src/pages/App/MediaLibrary.js Outdated Show resolved Hide resolved
joshuaellis
joshuaellis previously approved these changes Dec 13, 2022
View reviewed changes
@ronronscelestes
Copy link
Contributor Author

ronronscelestes commented Dec 16, 2022 •
edited

sorry for the approve dismissal, I updated the branch on main + caught a small UI issue (e.g. removed the table in BrowseStep when no assets or folders, and added a test case for it too)
@gu-stav @joshuaellis @jhoward1994 @Marc-Roig

jhoward1994
jhoward1994 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏻

@ronronscelestes ronronscelestes removed the flag: documentation This PR requires a documentation update label Dec 16, 2022
@ronronscelestes ronronscelestes added this to the 4.5.5 milestone Dec 16, 2022
@ronronscelestes ronronscelestes merged commit bf9c0d2 into main Dec 16, 2022
@ronronscelestes ronronscelestes deleted the features/MediaLibrary-listview branch December 16, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoward1994 jhoward1994 jhoward1994 approved these changes

@gu-stav gu-stav Awaiting requested review from gu-stav

@Marc-Roig Marc-Roig Awaiting requested review from Marc-Roig

@joshuaellis joshuaellis Awaiting requested review from joshuaellis

Assignees
No one assigned
Labels
pr: feature This PR adds a new feature source: core:upload Source is core/upload package
Projects
Content Platform Squad
Status: Fixed/Shipped
Milestone
4.5.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ronronscelestes @Marc-Roig @gu-stav @joshuaellis @jhoward1994 @pwizla