refactor(entity-manager): getDeepPopulate #14977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-pichon
added
source: core:content-manager
Codecov ReportBase: 59.68% // Head: 64.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14977 +/- ##
==========================================
+ Coverage 59.68% 64.26% +4.58%
==========================================
Files 1342 1055 -287
Lines 32629 22482 -10147
Branches 6224 3977 -2247
==========================================
- Hits 19473 14447 -5026
+ Misses 11293 7070 -4223
+ Partials 1863 965 -898
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nathan-pichon
force-pushed
the
refactor/deep-populate-entity-manager
branch
from
ff702a6
to
773adcc
Compare
petersg83
reviewed
Nov 28, 2022
packages/core/content-manager/server/services/utils/populate.js
Outdated
Show resolved
Hide resolved
packages/core/content-manager/server/services/utils/populate.js
Outdated
Show resolved
Hide resolved
packages/core/content-manager/server/services/utils/populate.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It split the getDeepPopulate function into smaller ones and clean unused parameter.
Why is it needed?
Reduce maintenance cost
How to test it?
As getDeepPopulate is used everywhere in the Entity manager, you can test pretty much any functionality about entities in the admin panel.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request