Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache action to cache node_modules #14976

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Use cache action to cache node_modules #14976

merged 2 commits into from
Nov 23, 2022

Conversation

alexandrebodin
Copy link
Member

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 59.61% // Head: 59.61% // No change to project coverage 👍

Coverage data is based on head (6658018) compared to base (879c7e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14976   +/-   ##
=======================================
  Coverage   59.61%   59.61%           
=======================================
  Files        1340     1340           
  Lines       32639    32639           
  Branches     6225     6225           
=======================================
  Hits        19459    19459           
  Misses      11316    11316           
  Partials     1864     1864           
Flag Coverage Δ
back 49.70% <ø> (ø)
front 64.13% <ø> (ø)
unit_back 49.70% <ø> (ø)
unit_front 64.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexandrebodin alexandrebodin marked this pull request as ready for review November 23, 2022 17:17
@alexandrebodin alexandrebodin added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 23, 2022
@joshuaellis
Copy link
Member

Do we know that that's the correct cache path?

From previous places i've had to get the cache directory, but then i've normally done this on ubuntu (and the example below uses v2).

CleanShot 2022-11-23 at 17 22 49@2x

@alexandrebodin
Copy link
Member Author

Do we know that that's the correct cache path?

From previous places i've had to get the cache directory, but then i've normally done this on ubuntu (and the example below uses v2).

CleanShot 2022-11-23 at 17 22 49@2x

Your screenshot is for caching yarn cache. Here I'm caching the node_modules directly as we have full control over the node version and can create the cache key based on it.

@joshuaellis
Copy link
Member

aha makes sense! 😄 thanks for explaining the diff!

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexandrebodin alexandrebodin added this to the 4.5.3 milestone Nov 23, 2022
@alexandrebodin alexandrebodin merged commit 988d1bd into main Nov 23, 2022
@alexandrebodin alexandrebodin deleted the chore/ci-caching branch November 23, 2022 17:38
@alexandrebodin alexandrebodin changed the title PoC cache actions Use cache action to cache node_modules Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants