Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14712: Query Parameter for Locale (API Documentation Plugin) #14885

Merged
merged 5 commits into from Nov 28, 2022

Conversation

raphaelmue
Copy link
Contributor

What does it do?

Adds a query parameter for locale.

Why is it needed?

There is no query parameter for locale generated into the API documentation.

How to test it?

  • Open Swagger API Documentation
  • Select any GET request
  • There there should be a new query parameter called locale

Related issue(s)/PR(s)

#14712

@strapi-cla
Copy link

strapi-cla commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@joshuaellis joshuaellis added source: plugin:documentation Source is plugin/documentation package pr: fix This PR is fixing a bug labels Nov 21, 2022
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raphaelmue thank you for this PR. The fix looks good to me but I see the PR is still in draft was there something else you still wanted to add?

@markkaylor markkaylor added this to the 4.5.3 milestone Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 59.61% // Head: 59.61% // No change to project coverage 👍

Coverage data is based on head (a9a695d) compared to base (c693065).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14885   +/-   ##
=======================================
  Coverage   59.61%   59.61%           
=======================================
  Files        1340     1340           
  Lines       32639    32639           
  Branches     6225     6225           
=======================================
  Hits        19459    19459           
  Misses      11316    11316           
  Partials     1864     1864           
Flag Coverage Δ
back 49.70% <ø> (ø)
front 64.13% <ø> (ø)
unit_back 49.70% <ø> (ø)
unit_front 64.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelmue raphaelmue marked this pull request as ready for review November 23, 2022 09:58
@raphaelmue
Copy link
Contributor Author

@markkaylor I just forgot to publish the draft. Now it can be merged.

@markkaylor markkaylor merged commit 25bcd1c into strapi:main Nov 28, 2022
@raphaelmue raphaelmue deleted the fix/swaggerParameterLocale branch December 6, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: plugin:documentation Source is plugin/documentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants