Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite invalid uid prefix error message #14870

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

jorgeRambla
Copy link
Contributor

What does it do?

Improve the quality of the error thrown when a new content type is registered with an invalid uid.

Why is it needed?

The code is checking that uid starts with api, plugin or admin but is throwing a message with a incorrect message.

How to test it?

Register a contentType with a no valid uid prefix.

Related issue(s)/PR(s)

Resolves #14869

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 59.76% // Head: 49.80% // Decreases project coverage by -9.96% ⚠️

Coverage data is based on head (d23ad06) compared to base (5a5d4b1).
Patch has no changes to coverable lines.

❗ Current head d23ad06 differs from pull request most recent head e0e24c1. Consider uploading reports for the commit e0e24c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14870      +/-   ##
==========================================
- Coverage   59.76%   49.80%   -9.97%     
==========================================
  Files        1339      290    -1049     
  Lines       32669    10184   -22485     
  Branches     6189     2252    -3937     
==========================================
- Hits        19526     5072   -14454     
+ Misses      11296     4214    -7082     
+ Partials     1847      898     -949     
Flag Coverage Δ
front ?
unit 49.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/pages/SettingsPage/pages/Users/ListPage/index.js
...t-manager/components/Wysiwyg/utils/continueList.js
packages/core/email/admin/src/utils/getTrad.js
...src/content-manager/components/BackHeader/index.js
...pe-builder/admin/src/utils/toRegressedEnumValue.js
...nager/components/DynamicTable/CellContent/index.js
...Page/components/LogoModalStepper/ImageCardAsset.js
...d/admin/src/components/MediaLibraryDialog/index.js
...uilder/admin/src/components/ComponentCard/index.js
...admin/admin/src/components/OverlayBlocker/index.js
... and 1039 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 21, 2022
@alexandrebodin alexandrebodin added this to the 4.5.3 milestone Nov 23, 2022
@alexandrebodin alexandrebodin merged commit 7d64a36 into strapi:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect logging message
4 participants