-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/fix iso locales #14835
Chore/fix iso locales #14835
Conversation
Codecov ReportBase: 49.80% // Head: 49.80% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #14835 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 290 290
Lines 10184 10184
Branches 2252 2252
=======================================
Hits 5072 5072
Misses 4214 4214
Partials 898 898
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how duplicates made their way into the file. That's quite concerning 🤔
Would you mind adding a quick unit test that reads the locales file & make sure there are no duplicates in it? This way, we prevent the same issue from happening in the future. WDYT?
@Convly good point! Done! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might be worth it for Derrick to validate the issue has been fixed in his exact scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What does it do?
Removes duplicate ISO locales
Why is it needed?
Duplicate ISO locales break UI of some elements
How to test it?
Run the
getstarted
app. Watch the video below. The issue in the video should be gone.https://www.loom.com/share/5c4a5d5683414bbab559c16ecb7a6ef8
Related issue(s)/PR(s)
#14752