New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace] Exp-373 Update the sort options in SelectSort component #14814
[Marketplace] Exp-373 Update the sort options in SelectSort component #14814
Conversation
c7a5f39
to
2b025ee
Compare
Codecov ReportBase: 58.99% // Head: 48.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14814 +/- ##
===========================================
- Coverage 58.99% 48.82% -10.17%
===========================================
Files 1349 289 -1060
Lines 32698 10127 -22571
Branches 6181 2234 -3947
===========================================
- Hits 19291 4945 -14346
+ Misses 11521 4267 -7254
+ Partials 1886 915 -971
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f8dd9c8
to
0293980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, don't forget the QA before merging :)
packages/core/admin/admin/src/pages/MarketplacePage/components/SortSelect/index.js
Outdated
Show resolved
Hide resolved
3526c3f
@madhurisandbhor is this ready to merge or are we waiting for QA? |
yes it is tested and ready to merge |
What does it do?
Added sort options "npm downloads" and "github stars" on the web marketplace Task:
How to test it?
Go to marketplace > plugins/providers tab > user can sort by new sort options