Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Exp-373 Update the sort options in SelectSort component #14814

Merged
merged 4 commits into from Nov 23, 2022

Conversation

madhurisandbhor
Copy link
Contributor

What does it do?

Added sort options "npm downloads" and "github stars" on the web marketplace Task:

  1. Number of GitHub stars (display the integrations with the biggest number of stars first)
  2. Number of downloads (display the integrations with the more downloads first)

How to test it?

Go to marketplace > plugins/providers tab > user can sort by new sort options

@madhurisandbhor madhurisandbhor force-pushed the feature/marketplace-additional-sort-options branch from c7a5f39 to 2b025ee Compare November 8, 2022 14:55
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 58.99% // Head: 48.82% // Decreases project coverage by -10.16% ⚠️

Coverage data is based on head (c940871) compared to base (511a024).
Patch has no changes to coverable lines.

❗ Current head c940871 differs from pull request most recent head 3526c3f. Consider uploading reports for the commit 3526c3f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #14814       +/-   ##
===========================================
- Coverage   58.99%   48.82%   -10.17%     
===========================================
  Files        1349      289     -1060     
  Lines       32698    10127    -22571     
  Branches     6181     2234     -3947     
===========================================
- Hits        19291     4945    -14346     
+ Misses      11521     4267     -7254     
+ Partials     1886      915      -971     
Flag Coverage Δ
front ?
unit 48.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/admin/admin/src/StrapiApp.js
...kages/core/admin/admin/src/pages/HomePage/index.js
...MarketplacePage/components/NpmPackageCard/index.js
...Page/components/NpmPackagesFilters/FilterSelect.js
...etplacePage/components/NpmPackagesFilters/index.js
...ges/MarketplacePage/components/SortSelect/index.js
...e/upload/admin/src/components/SelectTree/Option.js
...dmin/src/components/CustomRadioGroup/components.js
packages/core/admin/admin/src/utils/createRoute.js
...n/src/components/FolderCard/contexts/FolderCard.js
... and 1050 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madhurisandbhor madhurisandbhor added source: marketplace Source is admin in-app marketplace pr: feature This PR adds a new feature labels Nov 8, 2022
@madhurisandbhor madhurisandbhor added this to the 4.5.1 milestone Nov 8, 2022
@madhurisandbhor madhurisandbhor added pr: enhancement This PR adds or updates some part of the codebase or features and removed pr: feature This PR adds a new feature labels Nov 8, 2022
@madhurisandbhor madhurisandbhor force-pushed the feature/marketplace-additional-sort-options branch from f8dd9c8 to 0293980 Compare November 8, 2022 16:19
@madhurisandbhor madhurisandbhor marked this pull request as ready for review November 9, 2022 08:35
@markkaylor markkaylor self-assigned this Nov 9, 2022
markkaylor
markkaylor previously approved these changes Nov 9, 2022
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, don't forget the QA before merging :)

Feranchz
Feranchz previously approved these changes Nov 10, 2022
@Convly Convly modified the milestones: 4.5.1, 4.5.2 Nov 16, 2022
@remidej
Copy link
Contributor

remidej commented Nov 22, 2022

@madhurisandbhor is this ready to merge or are we waiting for QA?

@madhurisandbhor
Copy link
Contributor Author

@madhurisandbhor is this ready to merge or are we waiting for QA?

yes it is tested and ready to merge

@alexandrebodin alexandrebodin removed this from the 4.5.2 milestone Nov 22, 2022
@markkaylor markkaylor added this to the 4.5.3 milestone Nov 23, 2022
@madhurisandbhor madhurisandbhor merged commit c693065 into main Nov 23, 2022
@madhurisandbhor madhurisandbhor deleted the feature/marketplace-additional-sort-options branch November 23, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: marketplace Source is admin in-app marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants