Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump @strapi/design-system to 1.2.7 #14786

Merged
merged 1 commit into from Nov 4, 2022
Merged

Chore: Bump @strapi/design-system to 1.2.7 #14786

merged 1 commit into from Nov 4, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Nov 4, 2022

What does it do?

Bump @strapi/design-system to 1.2.7

➡️ Changelog

Why is it needed?

The release contains a critical fix for strapi/design-system#752.

@gu-stav gu-stav added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 4, 2022
Convly
Convly previously approved these changes Nov 4, 2022
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuaellis
joshuaellis previously approved these changes Nov 4, 2022
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be merged to main because relations is in main.

@joshuaellis joshuaellis changed the base branch from main to release/4.4.7 November 4, 2022 13:31
@gu-stav
Copy link
Contributor Author

gu-stav commented Nov 4, 2022

I'll leave the merge up to @Convly and let him decide how this will be released.

@joshuaellis joshuaellis changed the base branch from release/4.4.7 to main November 4, 2022 13:31
@joshuaellis joshuaellis dismissed stale reviews from Convly and themself November 4, 2022 13:31

The base branch was changed.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 58.72% // Head: 58.72% // No change to project coverage 👍

Coverage data is based on head (2ce5384) compared to base (2ce5384).
Patch has no changes to coverable lines.

❗ Current head 2ce5384 differs from pull request most recent head 9877172. Consider uploading reports for the commit 9877172 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14786   +/-   ##
=======================================
  Coverage   58.72%   58.72%           
=======================================
  Files        1339     1339           
  Lines       32491    32491           
  Branches     6143     6143           
=======================================
  Hits        19081    19081           
  Misses      11522    11522           
  Partials     1888     1888           
Flag Coverage Δ
front 63.20% <0.00%> (ø)
unit 48.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a new branch that starts at the 4.4.6 commit, this change should probably branch from there & merge back into there? Or just update that branch and then @Convly can release off that branch?

@Convly
Copy link
Member

Convly commented Nov 4, 2022

Let's merge this on main. I'll release 4.4.7 with this fix only.

@gu-stav gu-stav merged commit 885008c into main Nov 4, 2022
@gu-stav gu-stav deleted the chore/ds-1-2-7 branch November 4, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants