add media attribute validator

[Marc-Roig]

👋🏻 What does it do?

You could create an entity via the REST API with an empty media attribute that was required.
Now it will be required and you will receive a 400 Validation error.

🧪 How to test it?

Very well explained in #14648.

Example Content Type Schema

{
  "kind": "collectionType",
  "info": {
    "displayName": "Test",
    "singularName": "test",
    "pluralName": "tests",
    "description": ""
  },
  "options": {
    "draftAndPublish": false
  },
  "attributes": {
    "name": {
      "type": "string",
    },
    "media": {
      "type": "media",
      "multiple": false,
      "required": true,
      "allowedTypes": ["images", "files", "videos", "audios"]
    },
    "medias": {
      "allowedTypes": ["images", "files", "videos", "audios"],
      "type": "media",
      "multiple": true
    }
  }
}

Example Request

POST http://localhost:1337/api/tests

	{
	    "media": 10,
	    "medias": [{"id": 8}],
	    "name": "test"
	}

🔍 Expected behavior

Scenario 1: Single media attribute

• Given I have a content type with a required media attribute
• When I use the REST API to create an entity
  And I create it without the media attribute
• I receive a 400 Validation Error

Scenario 2: Multiple media attribute

• Given I have a content type with a required multiple media attribute
• When I use the REST API to create an entity
  And I create it without the multiple media attribute
• I receive a 400 Validation Error

🔗Related issue(s)/PR(s)

#14648

[codecov]

Codecov Report

Base: 58.41% // Head: 58.42% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9f78939) compared to base (85ff7d1).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14670      +/-   ##
==========================================
+ Coverage   58.41%   58.42%   +0.01%     
==========================================
  Files        1545     1546       +1     
  Lines       38203    38229      +26     
  Branches     7514     7517       +3     
==========================================
+ Hits        22315    22337      +22     
- Misses      13595    13599       +4     
  Partials     2293     2293              

Flag	Coverage Δ
back	47.40% <77.77%> (+0.01%)	⬆️
front	66.06% <ø> (+0.01%)	⬆️
unit_back	47.40% <77.77%> (+0.01%)	⬆️
unit_front	66.06% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...core/strapi/lib/services/entity-validator/index.js	90.81% <77.77%> (-0.72%)	⬇️
...es/core/admin/admin/src/pages/HomePage/CloudBox.js	88.23% <0.00%> (ø)
...re/admin/admin/src/pages/HomePage/ContentBlocks.js	72.22% <0.00%> (+1.63%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jhoward1994]

Looks good 🙂

[petersg83]

Interesting, I need to take the time to look at it as media are relations and we don't enforce "required" on relations. So I wonder what is currently done with media and what needs to be done.
Example: what happens if I delete the media afterwards?

[Marc-Roig]

Interesting, I need to take the time to look at it as media are relations and we don't enforce "required" on relations. So I wonder what is currently done with media and what needs to be done. Example: what happens if I delete the media afterwards?

That is a good point, and I think this is more of a product decision that was taken when we let users select media as required.
RN you can have required media field and delete the media afterwards. That leaves you with an invalid entity I guess. I can test this a little bit more to see what implications it has.

[Marc-Roig]

After further discussions, we have agreed to push this forward in order to be consistent with how the CM works.

[jhoward1994]

I think we should rename the test file now to a test.api.js file

[Marc-Roig]

@jhoward1994 good catch

[jhoward1994]

Looks good 👍🏻