New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate db config with all clients #14233
generate db config with all clients #14233
Conversation
Codecov ReportBase: 55.46% // Head: 55.46% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## features/db-config-env-var #14233 +/- ##
===========================================================
Coverage 55.46% 55.46%
===========================================================
Files 1274 1274
Lines 31847 31847
Branches 5745 5745
===========================================================
Hits 17664 17664
Misses 12364 12364
Partials 1819 1819
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
packages/generators/app/lib/resources/templates/database-templates/js/database.template
Outdated
Show resolved
Hide resolved
packages/generators/app/lib/resources/templates/database-templates/js/database.template
Show resolved
Hide resolved
packages/generators/app/lib/resources/templates/database-templates/js/database.template
Outdated
Show resolved
Hide resolved
packages/generators/app/lib/resources/templates/database-templates/js/database.template
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you want to add pool config in there?
@StrapiShaun All good on the doc side we can merge ? |
Yes. Will it be released next week or today? |
The next release will be next week :) @Marc-Roig If that's good for you then you can merge whenever |
That is good for me 🆗 . We have the documentation branch to merge too strapi/documentation#1212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What does it do?
It update the project generator to generator a database configuration that relies on env variables for the database selection.
With theses changes Strapi will support database connection strings using the
DATABASE_URL
env variable.Why is it needed?
This will unlock the possibility to chose your DB client on each environment without having to adapt your
config/database.js
How to test it?
.env
andconfig/database.{js|ts}
.Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request