Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eslint to ecma version 2020 #14191

Merged
merged 1 commit into from Aug 24, 2022
Merged

Move eslint to ecma version 2020 #14191

merged 1 commit into from Aug 24, 2022

Conversation

alexandrebodin
Copy link
Member

What does it do?

Update eslint config to all ecma2020 syntax in the backend

Why is it needed?

To allow features available from node versions > 12

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin changed the title Move to ecma2020 Move eslint to ecma version 2020 Aug 24, 2022
@alexandrebodin alexandrebodin marked this pull request as ready for review August 24, 2022 10:57
@alexandrebodin alexandrebodin added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Aug 24, 2022
@alexandrebodin alexandrebodin added this to the 4.3.5 milestone Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #14191 (f96ec5a) into main (ebac1f6) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

❗ Current head f96ec5a differs from pull request most recent head 554671c. Consider uploading reports for the commit 554671c to get more accurate results

@@            Coverage Diff             @@
##             main   #14191      +/-   ##
==========================================
- Coverage   55.58%   55.49%   -0.10%     
==========================================
  Files        1275     1274       -1     
  Lines       31829    31829              
  Branches     5733     5738       +5     
==========================================
- Hits        17692    17662      -30     
- Misses      12323    12354      +31     
+ Partials     1814     1813       -1     
Flag Coverage Δ
front 58.00% <33.33%> (-0.14%) ⬇️
unit 49.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/content-manager/components/DynamicTable/index.js 43.58% <0.00%> (-1.15%) ⬇️
...age/pages/ApiTokens/ListView/utils/tableHeaders.js 100.00% <ø> (ø)
packages/core/upload/admin/src/constants.js 100.00% <ø> (ø)
...ns/i18n/admin/src/components/ModalEdit/BaseForm.js 0.00% <0.00%> (ø)
...ges/SettingsPage/pages/ApiTokens/ListView/index.js 76.81% <100.00%> (+0.34%) ⬆️
...c/pages/SettingsPage/pages/Users/ListPage/index.js 81.66% <100.00%> (+0.31%) ⬆️
...ngsPage/pages/Users/ListPage/utils/tableHeaders.js 100.00% <100.00%> (ø)
...s/plugins/i18n/admin/src/hooks/useLocales/index.js 0.00% <0.00%> (-80.00%) ⬇️
...ns/i18n/admin/src/hooks/useDefaultLocales/index.js 0.00% <0.00%> (-76.20%) ⬇️
...ns/i18n/admin/src/components/LocaleSelect/index.js 93.10% <0.00%> (+31.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alexandrebodin alexandrebodin merged commit c0cc71d into main Aug 24, 2022
@alexandrebodin alexandrebodin deleted the chore/eslint-ecma2020 branch August 24, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant