Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM: Fix test errors for EditSettingsView #14182

Merged
merged 1 commit into from Aug 24, 2022
Merged

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Aug 23, 2022

What does it do?

Resolves console.error messages when running the tests.

Why is it needed?

Cleaner test output.

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: fix This PR is fixing a bug labels Aug 23, 2022
@gu-stav gu-stav added this to the 4.3.5 milestone Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #14182 (43a81dd) into main (8231bb9) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14182      +/-   ##
==========================================
- Coverage   55.58%   55.50%   -0.09%     
==========================================
  Files        1275     1274       -1     
  Lines       31833    31823      -10     
  Branches     5734     5734              
==========================================
- Hits        17695    17662      -33     
- Misses      12324    12349      +25     
+ Partials     1814     1812       -2     
Flag Coverage Δ
front 58.02% <ø> (-0.13%) ⬇️
unit 49.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugins/i18n/admin/src/hooks/useLocales/index.js 0.00% <0.00%> (-80.00%) ⬇️
...ns/i18n/admin/src/hooks/useDefaultLocales/index.js 0.00% <0.00%> (-76.20%) ⬇️
.../admin/src/components/LocaleSelect/tests/server.js
...ns/i18n/admin/src/components/LocaleSelect/index.js 93.10% <0.00%> (+31.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@gu-stav gu-stav merged commit 4356456 into main Aug 24, 2022
@gu-stav gu-stav deleted the fix/cm-edit-settings-view-tests branch August 24, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants