Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix eslint errors #14179

Merged
merged 2 commits into from Aug 23, 2022
Merged

Documentation: Fix eslint errors #14179

merged 2 commits into from Aug 23, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Aug 23, 2022

What does it do?

Fixes an eslint warning, which causes test failures on main.

Why is it needed?

Let's not state the obvious.

@gu-stav gu-stav added this to the 4.3.5 milestone Aug 23, 2022
@gu-stav gu-stav added source: plugin:documentation Source is plugin/documentation package pr: fix This PR is fixing a bug labels Aug 23, 2022
simotae14
simotae14 previously approved these changes Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #14179 (4d2f722) into main (bb4e94e) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d2f722 differs from pull request most recent head 365bcf3. Consider uploading reports for the commit 365bcf3 to get more accurate results

@@           Coverage Diff           @@
##             main   #14179   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files        1275     1275           
  Lines       31833    31833           
  Branches     5734     5734           
=======================================
  Hits        17695    17695           
  Misses      12324    12324           
  Partials     1814     1814           
Flag Coverage Δ
front 58.14% <ø> (ø)
unit 49.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gu-stav gu-stav merged commit 95575e4 into main Aug 23, 2022
@gu-stav gu-stav deleted the fix/eslint-main branch August 23, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: plugin:documentation Source is plugin/documentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants