Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix some test errors #14175

Merged
merged 7 commits into from Aug 23, 2022
Merged

chore: Fix some test errors #14175

merged 7 commits into from Aug 23, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Aug 23, 2022

What does it do?

This PR fixes some common prop-type and fixture issues in our tests.

Why is it needed?

To have a cleaner test output.

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Aug 23, 2022
@gu-stav gu-stav added this to the 4.3.5 milestone Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #14175 (bb4e94e) into main (f4c6a95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #14175   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files        1275     1275           
  Lines       31833    31833           
  Branches     5734     5734           
=======================================
  Hits        17695    17695           
  Misses      12324    12324           
  Partials     1814     1814           
Flag Coverage Δ
front 58.14% <ø> (ø)
unit 49.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/upload/admin/src/constants.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙏

@gu-stav gu-stav merged commit bd14f60 into main Aug 23, 2022
@gu-stav gu-stav deleted the fix/test-prop-types branch August 23, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants