Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Ignore process.exit eslint warnings #14119

Merged
merged 1 commit into from Aug 18, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Aug 17, 2022

What does it do?

Every PR has now a list of attached eslint warnings, which clutters them quite a bit. This PR adds eslint-ignore comments to each call to reduce that cluttering.

Screenshot 2022-08-17 at 15 42 57

An alternative would be to disable the warnings globally, but I think it is a good idea to leave it on.

Why is it needed?

Less warnings. They were introduced by #14017

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Aug 17, 2022
@gu-stav gu-stav added this to the 4.3.5 milestone Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #14119 (1194616) into main (e4e0981) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #14119   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files        1275     1275           
  Lines       31829    31829           
  Branches     5733     5733           
=======================================
  Hits        17692    17692           
  Misses      12323    12323           
  Partials     1814     1814           
Flag Coverage Δ
front 58.13% <ø> (ø)
unit 49.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just disable the rule instead as it will remove the warnings from eslint too. Can you just set it to off in the eslintrc file please?

@gu-stav
Copy link
Contributor Author

gu-stav commented Aug 17, 2022

@alexandrebodin Sure, I can do that too 👍🏼

I didn't do it, because I thought it is still valuable so that devs do add new calls only if it is really needed.

@alexandrebodin
Copy link
Member

@alexandrebodin Sure, I can do that too 👍🏼

I didn't do it, because I thought it is still valuable so that devs do add new calls only if it is really needed.

Yes that makes total sense.

I think we will enable it again later and go over all the calls again I'm not confident saying the current ones are all good :)

@gu-stav gu-stav force-pushed the chore/ignore-process-exit-warnings branch from 20f70fc to 1194616 Compare August 18, 2022 07:35
@gu-stav gu-stav merged commit f4035f4 into main Aug 18, 2022
@gu-stav gu-stav deleted the chore/ignore-process-exit-warnings branch August 18, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants