Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency updates #14050

Merged
merged 3 commits into from Aug 11, 2022
Merged

chore: dependency updates #14050

merged 3 commits into from Aug 11, 2022

Conversation

alexandrebodin
Copy link
Member

What does it do?

Why is it needed?

  • Very obvious :D

How to test it?

you can try the experimental release of these changes with npx create-strapi-app@experimental my-app

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #14050 (e2b3aa1) into chore/use-eslint-config (5f68b24) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           chore/use-eslint-config   #14050   +/-   ##
========================================================
  Coverage                    55.45%   55.45%           
========================================================
  Files                         1275     1275           
  Lines                        31812    31812           
  Branches                      5731     5731           
========================================================
  Hits                         17640    17640           
  Misses                       12355    12355           
  Partials                      1817     1817           
Flag Coverage Δ
front 58.13% <ø> (ø)
unit 48.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alexandrebodin alexandrebodin changed the base branch from master to chore/use-eslint-config August 10, 2022 08:52
@alexandrebodin alexandrebodin marked this pull request as ready for review August 10, 2022 09:22
package.json Outdated Show resolved Hide resolved
packages/core/admin/package.json Show resolved Hide resolved
packages/core/admin/package.json Show resolved Hide resolved
@gu-stav
Copy link
Contributor

gu-stav commented Aug 11, 2022

@alexandrebodin Looks like we need to add back the react-test-renderer dependency 🤔 ...

@alexandrebodin
Copy link
Member Author

@alexandrebodin Looks like we need to add back the react-test-renderer dependency 🤔 ...

Yes it's supposed to be optional but react-hooks seem to require it

Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexandrebodin
Copy link
Member Author

I'll wait for the eslint PR to be approved to merge this one 👍

Base automatically changed from chore/use-eslint-config to master August 11, 2022 14:19
@alexandrebodin alexandrebodin added this to the 4.3.5 milestone Aug 11, 2022
@alexandrebodin alexandrebodin added source: tooling Source is GitHub tooling/tests/ect and removed source: tooling Source is GitHub tooling/tests/ect labels Aug 11, 2022
@alexandrebodin alexandrebodin merged commit b5cfd21 into master Aug 11, 2022
@alexandrebodin alexandrebodin deleted the chore/deps-fix branch August 11, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants