Ignore if populating a scalar attribute #14032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersg83
added
source: core:database
Codecov Report
@@ Coverage Diff @@
## master #14032 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 1258 1258
Lines 31699 31699
Branches 5734 5734
=======================================
Hits 17546 17546
Misses 12337 12337
Partials 1816 1816
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexandrebodin
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Ignore instead of throwing an error when a query tried to populate a scalar attributes
NB: it is already this behavior when trying to populate an attribute that doesn't exist
Why is it needed?
To avoid error 500 in certain usecases.
Example :
When 2 components in a dynamic zone have the same field name but one is a relation and the other is a string.
How to test it?
The test was updated