properly reject promise in cloudinary provider

[Marc-Roig]

👋🏻 What does it do?

• Properly reject and throw an error when there is an issue uploading a file to cloudinary.

@gvocale provided the solution for the issue already.

❓ Why is it needed?

Cloudinary errors were not handled properly, and the server was crashing.

🧪 How to test it?

• Have a Cloudinary account for the provider options ( ask me if you need some and feel lazy ). Add them to the plugin configuration.
• Upload a pdf bigger than 10Mb in the media folder (Cloudinary free tier limit) (PDF I used)

You should see this error when trying to upload it:

🤔 Concerns

• When rejecting the promise with the PayloadTooLargeError error (or any other) I see this log on the console:

info: In application test-middleware middleware.
This error originated either by throwing inside an async function without a catch block or rejecting a promise not handled with .catch(). The promise was rejected with the reason:
{
  message: 'File size too large. Got 10615705. Maximum is 10485760.',
  name: 'Error',
  http_code: 400
}

I am not understanding why it is appearing or how to prevent it.

🔗 Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

[codecov]

Codecov Report

Merging #13992 (2148c4f) into master (d49d687) will decrease coverage by 5.96%.
The diff coverage is 100.00%.

❗ Current head 2148c4f differs from pull request most recent head 8668ba9. Consider uploading reports for the commit 8668ba9 to get more accurate results

@@            Coverage Diff             @@
##           master   #13992      +/-   ##
==========================================
- Coverage   55.34%   49.38%   -5.97%     
==========================================
  Files        1258      263     -995     
  Lines       31702     9287   -22415     
  Branches     5735     2019    -3716     
==========================================
- Hits        17546     4586   -12960     
+ Misses      12340     3877    -8463     
+ Partials     1816      824     -992     

Flag	Coverage Δ
front	?
unit	49.38% <100.00%> (+0.79%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.github/actions/check-pr-status/index.js	91.30% <100.00%> (ø)
...core/utils/lib/sanitize/visitors/allowed-fields.js	88.88% <0.00%> (-4.87%)	⬇️
packages/core/utils/lib/validators.js	85.71% <0.00%> (-1.08%)	⬇️
packages/core/upload/server/utils/file.js	21.73% <0.00%> (-0.99%)	⬇️
...e/utils/lib/sanitize/visitors/restricted-fields.js	12.50% <0.00%> (-0.84%)	⬇️
.../core/upload/server/services/image-manipulation.js	67.36% <0.00%> (-0.72%)	⬇️
...n/server/migrations/field/migrate-for-bookshelf.js	22.50% <0.00%> (-0.58%)	⬇️
packages/plugins/i18n/server/services/core-api.js	34.40% <0.00%> (-0.38%)	⬇️
.../core/admin/server/validation/common-validators.js	81.33% <0.00%> (-0.25%)	⬇️
packages/plugins/i18n/server/services/locales.js	95.45% <0.00%> (-0.11%)	⬇️
... and 1097 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[petersg83]

LGTM! I tried with cloudinary. Works as expected