chore: Unify template spacing #13901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
source: core:strapi
markkaylor
requested changes
Aug 8, 2022
| @@ -1,12 +1,12 @@ | |||
| 'use strict'; | |||
|
|
|||
| /** | |||
| * `{{id}}` policy. | |||
| * `{{ id }}` policy. | |||
There was a problem hiding this comment.
could you remove the . here as well to be consistent with the other files?
Codecov Report
@@ Coverage Diff @@
## master #13901 +/- ##
==========================================
+ Coverage 55.12% 55.35% +0.22%
==========================================
Files 1251 1258 +7
Lines 31493 31699 +206
Branches 5688 5734 +46
==========================================
+ Hits 17362 17546 +184
- Misses 12316 12337 +21
- Partials 1815 1816 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi, does PR wait on something I should do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Unify spacing with literals in Strapi repo
Describe the technical changes you did.
Changed every
{{variable}}to{{ variable }}Why is it needed?
Unification of code. Some parts has variables without spaces, some has with spaces
How to test it?
Related issue(s)/PR(s)
Screenshots