Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13453 Documentation Plugin doesn't generate Proper Type for the … #13458

Merged

Conversation

meganoob1337
Copy link
Contributor

fixes #13453

…r the Localization prop , and doesn't generate Refs for Components in Dynamic Zones
@alexandrebodin alexandrebodin added source: plugin:documentation Source is plugin/documentation package pr: fix This PR is fixing a bug labels Jun 5, 2022
@markkaylor
Copy link
Contributor

Thanks for this PR, I might be able to review it before the end of today, otherwise it will have to be early next week.

@meganoob1337
Copy link
Contributor Author

Thanks for this PR, I might be able to review it before the end of today, otherwise it will have to be early next week.

If you have any questions im in the strapi discord aswell.

I hope the code is okay like this, its my first PR here and was just my Fix for it, so bear with me please :D

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR, nice work! My comments are mostly about cleaning things up and code style. Let me know if you have any questions or if something isn't clear.

@meganoob1337
Copy link
Contributor Author

@markkaylor thx for the review and sorry for all the small things. ill probably come to it next week, as im away for the next days

@meganoob1337
Copy link
Contributor Author

Sorry, had corona, will start soon :)

@meganoob1337
Copy link
Contributor Author

@markkaylor any updates here?

@markkaylor
Copy link
Contributor

Sorry @meganoob1337 didn't see the notification that this PR was up for review again. I will take a look this week and get back to you.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #13458 (e68d494) into main (ce6c3f9) will increase coverage by 2.81%.
The diff coverage is n/a.

❗ Current head e68d494 differs from pull request most recent head 2143c2d. Consider uploading reports for the commit 2143c2d to get more accurate results

@@            Coverage Diff             @@
##             main   #13458      +/-   ##
==========================================
+ Coverage   55.12%   57.94%   +2.81%     
==========================================
  Files        1251     1006     -245     
  Lines       31493    22405    -9088     
  Branches     5688     3683    -2005     
==========================================
- Hits        17362    12982    -4380     
+ Misses      12316     8433    -3883     
+ Partials     1815      990     -825     
Flag Coverage Δ
front 57.94% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/utils/lib/sanitize/visitors/index.js
.../core/admin/server/validation/common-validators.js
packages/core/utils/lib/pipe-async.js
packages/core/upload/server/services/file.js
packages/core/admin/server/utils/index.js
packages/core/utils/lib/relations.js
...ckages/core/content-manager/server/services/uid.js
packages/core/utils/lib/traverse-entity.js
...ckages/core/database/lib/query/helpers/populate.js
...8n/server/migrations/content-type/disable/index.js
... and 235 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@meganoob1337
Copy link
Contributor Author

@markkaylor i added your requested Changes, have a look please :) (had some vacation - took a bit longer )

@markkaylor markkaylor self-requested a review August 11, 2022 09:54
@markkaylor markkaylor added this to the 4.3.5 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: plugin:documentation Source is plugin/documentation package
Projects
None yet
3 participants