New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #13453 Documentation Plugin doesn't generate Proper Type for the … #13458
fix #13453 Documentation Plugin doesn't generate Proper Type for the … #13458
Conversation
…r the Localization prop , and doesn't generate Refs for Components in Dynamic Zones
Thanks for this PR, I might be able to review it before the end of today, otherwise it will have to be early next week. |
If you have any questions im in the strapi discord aswell. I hope the code is okay like this, its my first PR here and was just my Fix for it, so bear with me please :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR, nice work! My comments are mostly about cleaning things up and code style. Let me know if you have any questions or if something isn't clear.
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/build-component-schema.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/build-component-schema.js
Outdated
Show resolved
Hide resolved
@markkaylor thx for the review and sorry for all the small things. ill probably come to it next week, as im away for the next days |
Sorry, had corona, will start soon :) |
…:meganoob1337/strapi into strapi/fix/issue-13453-documentation-fix
@markkaylor any updates here? |
Sorry @meganoob1337 didn't see the notification that this PR was up for review again. I will take a look this week and get back to you. |
packages/plugins/documentation/server/services/helpers/utils/clean-schema-attributes.js
Outdated
Show resolved
Hide resolved
packages/plugins/documentation/server/services/helpers/build-component-schema.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #13458 +/- ##
==========================================
+ Coverage 55.12% 57.94% +2.81%
==========================================
Files 1251 1006 -245
Lines 31493 22405 -9088
Branches 5688 3683 -2005
==========================================
- Hits 17362 12982 -4380
+ Misses 12316 8433 -3883
+ Partials 1815 990 -825
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@markkaylor i added your requested Changes, have a look please :) (had some vacation - took a bit longer ) |
fixes #13453