fix issue https://github.com/storybookjs/react-native/issues/24 #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Apr 20, 2020
ndelangen
added
react-native
bug
patch:yes
shilman
removed
the
patch:yes
|
This fix would be really good to have in a 5.3.x release because it fixes a bug in react-native-server, any chance that would be possible? |
shilman
pushed a commit
that referenced
this pull request
Aug 26, 2020
shilman
added
patch:yes
This was referenced Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: this commit 693f17e#diff-053b4430c28e7628f95731ed99a7723e from @core introduced a bug in react-native-server since v5.3.0-rc.6.
We can't see addon tabs anymore on the webpage as stated in this issue storybookjs/react-native#24
What I did
As @Gongreg stated, addon.js file is loaded only after provider.handleAPI(). It seems that is because entries order has been changed. This PR seems to put entries back in right order and makes addon tab reapear.
How to test
I don't know
No
No